Skip to content

fix(identity): update endpoint for Create/UpdateWorkloadIdentity#249

Merged
jariy17 merged 1 commit intoaws:mainfrom
spatch1923:main
Feb 4, 2026
Merged

fix(identity): update endpoint for Create/UpdateWorkloadIdentity#249
jariy17 merged 1 commit intoaws:mainfrom
spatch1923:main

Conversation

@spatch1923
Copy link
Contributor

Issue #, if available:

Description of changes:

This change updates the identity client to use the control plane endpoint for Create/UpdateWorkloadIdentity.

The Create/UpdateWorkloadIdentity functions were originally set up to use clients using the AgentCore data plane endpoint to avoid an old issue with local development. This issue has been fixed already, so these functions should use the control plane endpoint like the rest of the control plane operations.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@spatch1923 spatch1923 marked this pull request as ready for review February 3, 2026 19:45
@spatch1923 spatch1923 requested a review from a team February 3, 2026 19:45
@jariy17
Copy link
Contributor

jariy17 commented Feb 3, 2026

Please expand on this issue:
The Create/UpdateWorkloadIdentity functions were originally set up to use clients using the AgentCore data plane endpoint to avoid an old issue with local development.
What were original problem? Why was the hack introduce?

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@1de940d). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage        ?   90.52%           
=======================================
  Files           ?       35           
  Lines           ?     3421           
  Branches        ?      511           
=======================================
  Hits            ?     3097           
  Misses          ?      179           
  Partials        ?      145           
Flag Coverage Δ
unittests 90.52% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jariy17 jariy17 merged commit 3fa9afe into aws:main Feb 4, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants